netdev - Re: [PATCH net-next 0/9] mlx4: order-0 allocations and page recycling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b996d14-0471-1fa3-e686-15cf48db4c19@gmail.com>
Date:   Tue, 7 Feb 2017 17:50:00 +0200
From:   Tariq Toukan <ttoukan.linux@...il.com>
To:     Eric Dumazet <edumazet@...gle.com>,
        "David S . Miller" <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>,
        Tariq Toukan <tariqt@...lanox.com>,
        Martin KaFai Lau <kafai@...com>,
        Willem de Bruijn <willemb@...gle.com>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Brenden Blanco <bblanco@...mgrid.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH net-next 0/9] mlx4: order-0 allocations and page recycling

Hi Eric,

Thanks for your series.

On 07/02/2017 5:02 AM, Eric Dumazet wrote:
> As mentioned half a year ago, we better switch mlx4 driver to order-0
> allocations and page recycling.
>
> This reduces vulnerability surface thanks to better skb->truesize tracking
> and provides better performance in most cases.
The series makes significant change in the RX data-path, that requires 
deeper checks, in addition to code review.
We applied your series and started running both our functional and 
performance regression.
We will have results by tomorrow morning, and will analyze them during 
the day. I'll update about that.
>
> Worth noting this patch series deletes more than 100 lines of code ;)
>
> Eric Dumazet (9):
>    mlx4: use __skb_fill_page_desc()
>    mlx4: dma_dir is a mlx4_en_priv attribute
>    mlx4: remove order field from mlx4_en_frag_info
>    mlx4: get rid of frag_prefix_size
>    mlx4: rx_headroom is a per port attribute
>    mlx4: reduce rx ring page_cache size
>    mlx4: removal of frag_sizes[]
>    mlx4: use order-0 pages for RX
>    mlx4: add page recycling in receive path
>
>   drivers/net/ethernet/mellanox/mlx4/en_rx.c   | 350 +++++++++------------------
>   drivers/net/ethernet/mellanox/mlx4/en_tx.c   |   4 +-
>   drivers/net/ethernet/mellanox/mlx4/mlx4_en.h |  28 +--
>   3 files changed, 129 insertions(+), 253 deletions(-)
>
Thanks,
Tariq