netdev - Re: [PATCH net-next 9/9] mlx4: add page recycling in receive path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLVDLmnLU-CpLag=Rh31HgsaYE6JV--r+=Ahoc3QDwF8w@mail.gmail.com>
Date:   Tue, 7 Feb 2017 08:34:45 -0800
From:   Eric Dumazet <edumazet@...gle.com>
To:     Tariq Toukan <ttoukan.linux@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Tariq Toukan <tariqt@...lanox.com>,
        Martin KaFai Lau <kafai@...com>,
        Willem de Bruijn <willemb@...gle.com>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Brenden Blanco <bblanco@...mgrid.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH net-next 9/9] mlx4: add page recycling in receive path

On Tue, Feb 7, 2017 at 8:20 AM, Tariq Toukan <ttoukan.linux@...il.com> wrote:
>
>
> On 07/02/2017 5:02 AM, Eric Dumazet wrote:
>>
>> Same technique than some Intel drivers, for arches where PAGE_SIZE = 4096
>>
>> In most cases, pages are reused because they were consumed
>> before we could loop around the RX ring.
>
> This might not be true when multiple streams are handled in the same ring.
> As the process time in stack will be longer.
> We will test this scenario as well.

Sure thing. I already did ;)

I had a local patch adding a new "ethtool -S ... | grep
rx_page_allocs"  counter.

I could probably add it to the series.  (I noticed that
rx_alloc_failed was a dead counter)

Thanks.