netdev - Re: [PATCH net-next] bridge: avoid unnecessary read of jiffies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6bf4265-bc9c-a54f-953e-0a23bfcb656b@cumulusnetworks.com>
Date:   Tue, 7 Feb 2017 17:56:59 +0100
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org, roopa@...ulusnetworks.com,
        davem@...emloft.net, bridge@...ts.linux-foundation.org
Subject: Re: [PATCH net-next] bridge: avoid unnecessary read of jiffies

On 07/02/17 17:46, Stephen Hemminger wrote:
> 
> Jiffies is volatile so read it once.
> 
> Signed-off-by: Stephen Hemminger <sthemmin@...rosoft.com>
> ---
>  net/bridge/br_fdb.c   | 6 ++++--
>  net/bridge/br_input.c | 6 ++++--
>  2 files changed, 8 insertions(+), 4 deletions(-)
> 

Yep, good catch. Maybe you can use READ_ONCE() even though it's not needed just
to show why it's done this way.

Acked-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>