netdev - Re: [PATCH net v2] mlx4: Invoke softirqs after napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170207.125154.1590393488220239361.davem@davemloft.net>
Date:   Tue, 07 Feb 2017 12:51:54 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     bpoirier@...e.com
Cc:     netdev@...r.kernel.org, tariqt@...lanox.com, yishaih@...lanox.com,
        linux-rdma@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net v2] mlx4: Invoke softirqs after napi_reschedule

From: Benjamin Poirier <bpoirier@...e.com>
Date: Mon,  6 Feb 2017 10:14:31 -0800

> mlx4 may schedule napi from a workqueue. Afterwards, softirqs are not run
> in a deterministic time frame and the following message may be logged:
> NOHZ: local_softirq_pending 08
> 
> The problem is the same as what was described in commit ec13ee80145c
> ("virtio_net: invoke softirqs after __napi_schedule") and this patch
> applies the same fix to mlx4.
> 
> Fixes: 07841f9d94c1 ("net/mlx4_en: Schedule napi when RX buffers allocation fails")
> Cc: Eric Dumazet <eric.dumazet@...il.com>
> Signed-off-by: Benjamin Poirier <bpoirier@...e.com>

Applied and queued up for -stable, thanks!