netdev - Re: [PATCH 1/2] sierra_net: Add support for IPv6 and Dual-Stack Link Sense Indications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170207.125825.646803866093568777.davem@davemloft.net>
Date:   Tue, 07 Feb 2017 12:58:25 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     stefan.bruens@...h-aachen.de
Cc:     linux-usb@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] sierra_net: Add support for IPv6 and Dual-Stack
 Link Sense Indications

From: Stefan Brüns <stefan.bruens@...h-aachen.de>
Date: Mon, 6 Feb 2017 21:20:33 +0100

>  
>  	/* Validate the protocol  - only support UMTS for now */
> -	if (lsi->protocol != SIERRA_NET_PROTOCOL_UMTS) {
> +	if (lsi->protocol == SIERRA_NET_PROTOCOL_UMTS) {
 ...
> +	} else if (lsi->protocol == SIERRA_NET_PROTOCOL_UMTS_DS) {
> +		expected_length = SIERRA_NET_LSI_UMTS_DS_STATUS_LEN;

If you are now supporting more protocols, that comment is not correct
any longer.  You therefore need to update it or remove it.

Thanks.