netdev - Re: [PATCH net-next] sctp: drop __packed from almost all SCTP structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170207.141123.633919678220393477.davem@davemloft.net>
Date:   Tue, 07 Feb 2017 14:11:23 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     marcelo.leitner@...il.com
Cc:     netdev@...r.kernel.org, linux-sctp@...r.kernel.org,
        vyasevich@...il.com, nhorman@...driver.com, David.Laight@...LAB.COM
Subject: Re: [PATCH net-next] sctp: drop __packed from almost all SCTP
 structures

From: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Date: Tue,  7 Feb 2017 11:37:56 -0200

> __packed is considered harmful as it potentially generates code that
> doesn't perform well and its usage should be avoided as much as
> possible.
> 
> This patch drops __packed from all SCTP structures except one, which is
> sctp_signed_cookie. In there it's required, as per changelog on
> commit 9834a2bb4970 ("[SCTP]: Fix sctp_cookie alignment in the packet.").
> 
> After this patch, no alignment changes neither in x86 or x86_64 and
> no exceptions were noticed during testing on both archs.
> 
> Code size for SCTP module also didn't change with this patch.
> 
> Cc: David Miller <davem@...emloft.net>
> Cc: David Laight <David.Laight@...LAB.COM>
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>

Looks great, thanks so much for following through on this!

Applied.