netdev - Re: [PATCH net 1/1] net: sock: Use double send/recv buff value to compare with max value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1486569601.7793.83.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Wed, 08 Feb 2017 08:00:01 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     fgao@...ai8.com
Cc:     davem@...emloft.net, netdev@...r.kernel.org, gfree.wind@...il.com
Subject: Re: [PATCH net 1/1] net: sock: Use double send/recv buff value to
 compare with max value

On Wed, 2017-02-08 at 21:07 +0800, fgao@...ai8.com wrote:
> From: Gao Feng <fgao@...ai8.com>
> 
> Because the value of SO_SNDBUF and SO_RCVBUF is doubled before
> assignment, so the real value of send and recv buffer could be more
> than the max sysctl config sysctl_wmem_max and sysctl_rmem_max.
> 
> Now use doulbe send/recv buffer value to compare with sysctl_wmem_max
> and sysctl_rmem_max, and it keeps consistence with SOCK_MIN_SNDBUF
> and SOCK_MIN_RCVBUF.
> 
> Signed-off-by: Gao Feng <fgao@...ai8.com>
> ---

Looks completely bogus, based on your comprehension of this code.

If you need to, fix the doc, not this code.

Unless you give more details of course, why we should take your patch.