netdev - Re: [PATCH net] ipv6: addrconf: fix generation of new temporary addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170208.115519.683941247979533576.davem@davemloft.net>
Date:   Wed, 08 Feb 2017 11:55:19 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     suse-tux@....de
Cc:     kuznet@....inr.ac.ru, jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
        kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: [PATCH net] ipv6: addrconf: fix generation of new temporary
 addresses

From: Marcus Huewe <suse-tux@....de>
Date: Mon, 6 Feb 2017 18:34:56 +0100

> Under some circumstances it is possible that no new temporary addresses
> will be generated.
> 
> For instance, addrconf_prefix_rcv_add_addr() indirectly calls
> ipv6_create_tempaddr(), which creates a tentative temporary address and
> starts dad. Next, addrconf_prefix_rcv_add_addr() indirectly calls
> addrconf_verify_rtnl(). Now, assume that the previously created temporary
> address has the least preferred lifetime among all existing addresses and
> is still tentative (that is, dad is still running). Hence, the next run of
> addrconf_verify_rtnl() is performed when the preferred lifetime of the
> temporary address ends. If dad succeeds before the next run, the temporary
> address becomes deprecated during the next run, but no new temporary
> address is generated.
> 
> In order to fix this, schedule the next addrconf_verify_rtnl() run slightly
> before the temporary address becomes deprecated, if dad succeeded.
> 
> Signed-off-by: Marcus Huewe <suse-tux@....de>

Applied, thank you.