netdev - Re: [PATCH iproute2/net-next repost2] tc: flower: use correct type when calling flower_icmp_attr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170208113906.587df2a2@xeon-e3>
Date:   Wed, 8 Feb 2017 11:39:06 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Simon Horman <simon.horman@...ronome.com>
Cc:     Jiri Pirko <jiri@...nulli.us>,
        Dinan Gunawardena <dinan.gunawardena@...ronome.com>,
        netdev@...r.kernel.org, oss-drivers@...ronome.com
Subject: Re: [PATCH iproute2/net-next repost2] tc: flower: use correct type
 when calling flower_icmp_attr_type

On Wed,  8 Feb 2017 13:04:31 +0100
Simon Horman <simon.horman@...ronome.com> wrote:

> Use enum flower_icmp_field rather than bool as type of third parameter
> when calling flower_icmp_attr_type.
> 
> Fixes: eb3b5696f163 ("tc: flower: support matching on ICMP type and code")
> Signed-off-by: Simon Horman <simon.horman@...ronome.com>
> ---
> * Reposted a second time due to send-mail set-up error
> * Reposted after breaking out of a larger patch-set
> * This should not have a run-time affect assuming both false and
>   FLOWER_ICMP_FIELD_TYPE - the first value of enum flower_icmp_field -
>   are zero.

Applied to net-next