netdev - Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5fe312c8-e59e-669c-cd29-f6773adcd8e5@gmail.com>
Date:   Wed, 8 Feb 2017 11:45:11 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Kalle Valo <kvalo@...eaurora.org>,
        David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, linux-mips@...ux-mips.org,
        linux-nfs@...r.kernel.org, linux-scsi@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-wireless@...r.kernel.org,
        target-devel@...r.kernel.org, andrew@...n.ch,
        anna.schumaker@...app.com, derek.chickles@...iumnetworks.com,
        felix.manlunas@...iumnetworks.com, bfields@...ldses.org,
        jlayton@...chiereds.net, jirislaby@...il.com,
        mcgrof@...not-panic.com, madalin.bucur@....com,
        UNGLinuxDriver@...rochip.com, nab@...ux-iscsi.org,
        mickflemm@...il.com, nicolas.ferre@...el.com,
        raghu.vatsavayi@...iumnetworks.com, ralf@...ux-mips.org,
        satananda.burla@...iumnetworks.com,
        thomas.petazzoni@...e-electrons.com, timur@...eaurora.org,
        trond.myklebust@...marydata.com,
        vivien.didelot@...oirfairelinux.com, woojung.huh@...rochip.com
Subject: Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h
 include

On 02/08/2017 08:11 AM, Kalle Valo wrote:
> David Miller <davem@...emloft.net> writes:
> 
>> From: Florian Fainelli <f.fainelli@...il.com>
>> Date: Tue,  7 Feb 2017 15:02:53 -0800
>>
>>> I'm hoping this doesn't conflict with what's already in net-next...
>>>
>>> David, this should probably go via your tree considering the diffstat.
>>
>> I think you need one more respin.  Are you doing an allmodconfig build?

I did not, instead tried to test each driver individually in different
configurations...

>> If not, for something like this it's a must:
>>
>> drivers/net/wireless/ath/wil6210/cfg80211.c:24:30: error: expected ‘)’ before ‘bool’
>>  module_param(disable_ap_sme, bool, 0444);
>>                               ^
>> drivers/net/wireless/ath/wil6210/cfg80211.c:25:34: error: expected ‘)’ before string constant
>>  MODULE_PARM_DESC(disable_ap_sme, " let user space handle AP mode SME");
>>                                   ^
>> Like like that file needs linux/module.h included.
> 
> Johannes already fixed a similar (or same) problem in my tree:
> 
> wil6210: include moduleparam.h
> 
> https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=949c2d0096753d518ef6e0bd8418c8086747196b
> 
> I'm planning to send you a pull request tomorrow which contains that
> one.

Thanks Kalle!

David, can you hold on this series until Kalle's pull request gets
submitted? Past this error, allmodconfig builds fine with this patch
series (just tested). Thanks!
-- 
Florian