netdev - Re: [PATCH net] net: dsa: Do not destroy invalid network devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170208.145124.384553956748848714.davem@davemloft.net>
Date:   Wed, 08 Feb 2017 14:51:24 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     f.fainelli@...il.com
Cc:     netdev@...r.kernel.org, andrew@...n.ch,
        vivien.didelot@...oirfairelinux.com
Subject: Re: [PATCH net] net: dsa: Do not destroy invalid network devices

From: Florian Fainelli <f.fainelli@...il.com>
Date: Tue,  7 Feb 2017 23:10:13 -0800

> dsa_slave_create() can fail, and dsa_user_port_unapply() will properly check
> for the network device not being NULL before attempting to destroy it. We were
> not setting the slave network device as NULL if dsa_slave_create() failed, so
> we would later on be calling dsa_slave_destroy() on a now free'd and
> unitialized network device, causing crashes in dsa_slave_destroy().
> 
> Fixes: 83c0afaec7b7 ("net: dsa: Add new binding implementation")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Applied and queued up for -stable, thanks.