netdev - Re: [patch net-next] mlxsw: acl: Fix mlxsw_afa_block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170208.151408.2292767944646557589.davem@davemloft.net>
Date:   Wed, 08 Feb 2017 15:14:08 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     netdev@...r.kernel.org, idosch@...lanox.com, eladr@...lanox.com,
        mlxsw@...lanox.com, dan.carpenter@...cle.com
Subject: Re: [patch net-next] mlxsw: acl: Fix mlxsw_afa_block_commit error
 path

From: Jiri Pirko <jiri@...nulli.us>
Date: Wed,  8 Feb 2017 10:39:16 +0100

> From: Jiri Pirko <jiri@...lanox.com>
> 
> No rollback is needed since the chain is in consistent state and
> mlxsw_afa_block_destroy() will take care of putting it away. So remove
> the one we have now which is wrong. Also move the set of 'finished' flag
> to the beginning of the function, because the block is certainly unusable
> for future action addition no matter if the function succeeds or not.
> 
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Fixes: 4cda7d8d7098 ("mlxsw: core: Introduce flexible actions support")
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>
> Acked-by: Ido Schimmel <idosch@...lanox.com>

Applied.