netdev - Re: [PATCHv4 net-next 0/7] net: dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.11.1702082245270.2608@ja.home.ssi.bg>
Date:   Wed, 8 Feb 2017 23:05:36 +0200 (EET)
From:   Julian Anastasov <ja@....bg>
To:     David Miller <davem@...emloft.net>
cc:     netdev@...r.kernel.org, linux-sctp@...r.kernel.org,
        nhorman@...driver.com, steffen.klassert@...unet.com,
        linux-rdma@...r.kernel.org, yuehaibing@...wei.com
Subject: Re: [PATCHv4 net-next 0/7] net: dst_confirm replacement


	Hello,

On Tue, 7 Feb 2017, David Miller wrote:

> From: Julian Anastasov <ja@....bg>
> Date: Mon,  6 Feb 2017 23:14:10 +0200
> 
> > - I failed to understand the CXGB* code, I see dst_confirm()
> > calls but I'm not sure dst_neigh_output() was called. For now
> > I just removed the dst->pending_confirm flag and left all
> > dst_confirm() calls there. Any better idea?
> 
> As I said, it is trying to confirm neighbours based upon traffic
> occurring in the chips TCP offload stack.  The 'cm' in "iwch_cm.c"
> means "connection manager".
> 
> We can probably get to the neigh that will end up being used
> since there should be a flow key somewhere that we can use to
> determine the nexthop address for neigh lookup.

	I was reluctant to add slow neigh lookup there,
I was not sure if there is a saved address somewhere, for
the all places that call dst_confirm.

> > - Now may be old function neigh_output() should be restored
> > instead of dst_neigh_output?
> 
> Please elaborate.

	As dst_neigh_output does not use the dst arg anymore,
my idea was to rename dst_neigh_output to neigh_output, i.e.
just like it was before commit 5110effee8fd ("net: Do delayed neigh 
confirmation."

Regards

--
Julian Anastasov <ja@....bg>