netdev - Re: [PATCH] xen-netfront: Delete rx_refill_timer in xennet_disconnect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa4ea104-4283-e707-019e-dee89dc66f3e@oracle.com>
Date:   Thu, 9 Feb 2017 08:42:59 -0500
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     unlisted-recipients:; (no To-header on input)
Cc:     Juergen Gross <jgross@...e.com>, xen-devel@...ts.xenproject.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        vineethp@...zon.com, wei.liu2@...rix.com, paul.durrant@...rix.com,
        stable@...r.kernel.org, "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] xen-netfront: Delete rx_refill_timer in
 xennet_disconnect_backend()



On 02/03/2017 04:38 AM, Juergen Gross wrote:
> On 30/01/17 18:45, Boris Ostrovsky wrote:
>> rx_refill_timer should be deleted as soon as we disconnect from the
>> backend since otherwise it is possible for the timer to go off before
>> we get to xennet_destroy_queues(). If this happens we may dereference
>> queue->rx.sring which is set to NULL in xennet_disconnect_backend().
>>
>> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@...cle.com>
>> CC: stable@...r.kernel.org
>
> Reviewed-by: Juergen Gross <jgross@...e.com>



David,

Are you going to take this to your tree or would you rather it goes via 
Xen tree?

And the same question for

https://lists.xenproject.org/archives/html/xen-devel/2017-02/msg00625.html

and

https://lists.xenproject.org/archives/html/xen-devel/2017-02/msg00754.html


(And while I am at it, I took

https://lists.xenproject.org/archives/html/xen-devel/2017-01/msg00833.html

to Xen tree, hope you don't mind)


-boris