netdev - interrupt handling in the new aquantia ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20170209140157.GA13338@lst.de>
Date:   Thu, 9 Feb 2017 15:01:57 +0100
From:   Christoph Hellwig <hch@....de>
To:     David VomLehn <vomlehn@...as.net>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: interrupt handling in the new aquantia ethernet driver

Hi David,

commit a4d36e20 ("net: ethernet: aquantia: PCI operations") adds some
realy odd interrupt related code, including a call to the long
gone pci_enable_msix() function.  I first wondered how this compiles.
but the code happens to be under

#if AQ_CFG_FORCE_LEGACY_INT

where AQ_CFG_FORCE_LEGACY_INT is defined to 0U, so it isn't compiled in,
although probably not intentionally.  

It would be good to a) kill that ifdef and b) either remove the MSI-X
code entirely or switch it to the proper pci_alloc_irq_vectors API.