netdev - Re: [PATCH net] udp: fix a potential panic in first_packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1486662860.7793.106.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Thu, 09 Feb 2017 09:54:20 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Andrey Konovalov <andreyknvl@...gle.com>
Subject: Re: [PATCH net] udp: fix a potential panic in first_packet_length()

On Thu, 2017-02-09 at 18:01 +0100, Paolo Abeni wrote:
>  
> 
> My bad, I missed completely that call path.
> 
> I'm wondering if calling first_packet_length() for l2tp_ip sockets
> makes sense ?!? Am I missing something or it touches udp stats and
> checks udp csum for non udp packets ?!?

Yes, I guess this is a good point.

I will send a v2, thanks.