netdev - Re: [patch net-next 6/6] sched: check negative err value to safe one level of indent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <da6c4be4-e35c-1ea2-36f5-109ca0aa5bb6@mojatatu.com>
Date:   Thu, 9 Feb 2017 13:32:21 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, mlxsw@...lanox.com
Subject: Re: [patch net-next 6/6] sched: check negative err value to safe one
 level of indent

On 17-02-09 08:39 AM, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...lanox.com>
>
> As it is more common, check err for !0. That allows to safe one level of
> indentation and makes the code easier to read. Also, make 'next' variable
> global in function as it is used twice.
>
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

Acked-by: Jamal Hadi Salim <jhs@...atatu.com>

BTW: Another nice cleanup is to separate for better
readability/maintainability DEL/GET/NEW into
their own functions. GET/DEL are very close but sometimes are
slightly different - in the action code they are already breaking.

cheers,
jamal