netdev - Re: [PATCH v3] xen-netfront: Improve error handling during initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170209.164655.35358163111689337.davem@davemloft.net>
Date:   Thu, 09 Feb 2017 16:46:55 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     ross.lagerwall@...rix.com
Cc:     xen-devel@...ts.xenproject.org, netdev@...r.kernel.org,
        boris.ostrovsky@...cle.com, jgross@...e.com,
        linux-kernel@...r.kernel.org, wei.liu2@...rix.com
Subject: Re: [PATCH v3] xen-netfront: Improve error handling during
 initialization

From: Ross Lagerwall <ross.lagerwall@...rix.com>
Date: Wed, 8 Feb 2017 10:57:37 +0000

> This fixes a crash when running out of grant refs when creating many
> queues across many netdevs.
> 
> * If creating queues fails (i.e. there are no grant refs available),
> call xenbus_dev_fatal() to ensure that the xenbus device is set to the
> closed state.
> * If no queues are created, don't call xennet_disconnect_backend as
> netdev->real_num_tx_queues will not have been set correctly.
> * If setup_netfront() fails, ensure that all the queues created are
> cleaned up, not just those that have been set up.
> * If any queues were set up and an error occurs, call
> xennet_destroy_queues() to clean up the napi context.
> * If any fatal error occurs, unregister and destroy the netdev to avoid
> leaving around a half setup network device.
> 
> Signed-off-by: Ross Lagerwall <ross.lagerwall@...rix.com>

Applied.