netdev - Re: [PATCH net] igmp, mld: Fix memory leak in igmpv3/mld_del

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170209.164704.601696075811710644.davem@davemloft.net>
Date:   Thu, 09 Feb 2017 16:47:04 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     liuhangbin@...il.com
Cc:     netdev@...r.kernel.org, daniel@...earbox.net
Subject: Re: [PATCH net] igmp, mld: Fix memory leak in
 igmpv3/mld_del_delrec()

From: Hangbin Liu <liuhangbin@...il.com>
Date: Wed,  8 Feb 2017 21:16:45 +0800

> In function igmpv3/mld_add_delrec() we allocate pmc and put it in
> idev->mc_tomb, so we should free it when we don't need it in del_delrec().
> But I removed kfree(pmc) incorrectly in latest two patches. Now fix it.
> 
> Fixes: 24803f38a5c0 ("igmp: do not remove igmp souce list info when ...")
> Fixes: 1666d49e1d41 ("mld: do not remove mld souce list info when ...")
> Reported-by: Daniel Borkmann <daniel@...earbox.net>
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>

Applied and queued up for -stable, thanks.