netdev - Re: [PATCH net v3 1/2] net: ethernet: bgmac: init sequence bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170209.170422.2219490608301068441.davem@davemloft.net>
Date:   Thu, 09 Feb 2017 17:04:22 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     jon.mason@...adcom.com
Cc:     rafal@...ecki.pl, bcm-kernel-feedback-list@...adcom.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        zschroff@...adcom.com
Subject: Re: [PATCH net v3 1/2] net: ethernet: bgmac: init sequence bug

From: Jon Mason <jon.mason@...adcom.com>
Date: Wed,  8 Feb 2017 16:12:56 -0500

> The code now checks to see if the adapter needs to be brought out of
> reset (where as before it was doing an IDM write to bring it out of
> reset regardless of whether it was in reset or not).  Also, removed
> unnecessary usleeps (as there is already a read present to flush the
> IDM writes).

That's not what the delays are there for, I don't think you can
safely remove them.

It's for waiting for the reset to complete after the write to
the register has propagated by the read back.

Please retain the delays.

Thanks.