netdev - R: Re: [PATCH net] lwtunnel: valid encap attr check should return 0 when lwtunnel is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <533381532.379531486630138912.JavaMail.httpd@webmail-35.iol.local>
Date:   Thu, 9 Feb 2017 09:48:58 +0100 (CET)
From:   "pupilla@...ero.it" <pupilla@...ero.it>
To:     David Miller <davem@...emloft.net>, <dsa@...ulusnetworks.com>
Cc:     <netdev@...r.kernel.org>
Subject: R: Re: [PATCH net] lwtunnel: valid encap attr check should return 0
 when lwtunnel is disabled

David Miller wrote:

>Data: 8-feb-2017 18.55
>A: <dsa@...ulusnetworks.com>
>Cc: <netdev@...r.kernel.org>, <pupilla@...ero.it>
>Ogg: Re: [PATCH net] lwtunnel: valid encap attr check should return 0 when 
lwtunnel is disabled
>
>From: David Ahern <dsa@...ulusnetworks.com>
>Date: Wed,  8 Feb 2017 09:29:00 -0800
>
>> An error was reported upgrading to 4.9.8:
>>     root@...hoon:~# ip route add default table 210 nexthop dev eth0 via 
10.68.64.1
>>     weight 1 nexthop dev eth0 via 10.68.64.2 weight 1
>>     RTNETLINK answers: Operation not supported
>> 
>> The problem occurs when CONFIG_LWTUNNEL is not enabled and a multipath
>> route is submitted.
>> 
>> The point of lwtunnel_valid_encap_type_attr is catch modules that
>> need to be loaded before any references are taken with rntl held. With
>> CONFIG_LWTUNNEL disabled, there will be no modules to load so the
>> lwtunnel_valid_encap_type_attr stub should just return 0.
>> 
>> Fixes: 9ed59592e3e3 ("lwtunnel: fix autoload of lwt modules")
>> Reported-by: pupilla@...ero.it
>> Signed-off-by: David Ahern <dsa@...ulusnetworks.com>
>
>Applied and queued up for -stable, thanks for fixing this so quickly David.

Thanks everybody. I have applied the patch to linux-4.9.8 and all is fine.

Thanks again.

Marco