netdev - RE: [PATCH net] net: hns: Fix the device being used for dma mapping during TX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F4CC6FACFEB3C54C9141D49AD221F7F91A860E3E@lhreml503-mbx>
Date:   Thu, 9 Feb 2017 11:30:13 +0000
From:   Salil Mehta <salil.mehta@...wei.com>
To:     Lino Sanfilippo <LinoSanfilippo@....de>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "Zhuangyuzeng (Yisen)" <yisen.zhuang@...wei.com>,
        "mehta.salil.lnk@...il.com" <mehta.salil.lnk@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linuxarm <linuxarm@...wei.com>,
        "Yankejian (Hackim Yim)" <yankejian@...wei.com>
Subject: RE: [PATCH net] net: hns: Fix the device being used for dma mapping
 during TX

> -----Original Message-----
> From: Lino Sanfilippo [mailto:LinoSanfilippo@....de]
> Sent: Thursday, February 09, 2017 10:25 AM
> To: Salil Mehta
> Cc: davem@...emloft.net; Salil Mehta; Zhuangyuzeng (Yisen);
> mehta.salil.lnk@...il.com; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; Linuxarm; Yankejian (Hackim Yim)
> Subject: Re: [PATCH net] net: hns: Fix the device being used for dma
> mapping during TX
> 
> Hi,
> 
> > From: Kejian Yan <yankejian@...wei.com>
> >
> > This patch fixes the device being used to DMA map skb->data.
> > Erroneous device assignment causes the crash when SMMU is enabled.
> > This happens during TX since buffer gets DMA mapped with device
> > correspondign to net_device and gets unmapped using the device
> > related to DSAF.
> >
> > Signed-off-by: Kejian Yan <yankejian@...wei.com>
> > Reviewed-by: Yisen Zhuang <yisen.zhuang@...wei.com>
> > Signed-off-by: Salil Mehta <salil.mehta@...wei.com>
> > ---
> >  drivers/net/ethernet/hisilicon/hns/hns_enet.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c
> b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
> > index 672b646..2b52a12 100644
> > --- a/drivers/net/ethernet/hisilicon/hns/hns_enet.c
> > +++ b/drivers/net/ethernet/hisilicon/hns/hns_enet.c
> > @@ -305,7 +305,7 @@ int hns_nic_net_xmit_hw(struct net_device *ndev,
> >  			struct hns_nic_ring_data *ring_data)
> >  {
> >  	struct hns_nic_priv *priv = netdev_priv(ndev);
> > -	struct device *dev = priv->dev;
> > +	struct device *dev = ring_to_dev(ring_data->ring);
> >  	struct hnae_ring *ring = ring_data->ring;
> >  	struct netdev_queue *dev_queue;
> >  	struct skb_frag_struct *frag;
> > --
> 
> I would say it should be the other way around: Use priv->dev for
> mapping and
> unmapping instead of ring_to_dev().
Yes, you got it right. Ideally, it should be per-port and for
legacy reasons we have it this way. In the current design, we have
SMMU node per-dsaf and I guess we will not land in the right
dma-ops if we use per-netdev platform-device/device right now.

Best regards
Salil
> 
> Regards,
> Lino