netdev - Re: [PATCH iproute] tc: matchall: Print skip flags when dumping a filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170210153628.GA24176@penelope.horms.nl>
Date:   Fri, 10 Feb 2017 16:36:29 +0100
From:   Simon Horman <simon.horman@...ronome.com>
To:     Or Gerlitz <ogerlitz@...lanox.com>
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        netdev@...r.kernel.org
Subject: Re: [PATCH iproute] tc: matchall: Print skip flags when dumping a
 filter

On Thu, Feb 09, 2017 at 03:10:14PM +0200, Or Gerlitz wrote:
> Print the skip flags when we dump a filter.
> 
> Signed-off-by: Or Gerlitz <ogerlitz@...lanox.com>
> Acked by: Yotam Gigi <yotamg@...lanox.com>

This appears to be consistent with other classifiers that support these
flags.

Reviewed-by: Simon Horman <simon.horman@...ronome.com>

> ---
>  tc/f_matchall.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/tc/f_matchall.c b/tc/f_matchall.c
> index 04e524e..ac48630 100644
> --- a/tc/f_matchall.c
> +++ b/tc/f_matchall.c
> @@ -130,6 +130,15 @@ static int matchall_print_opt(struct filter_util *qu, FILE *f,
>  			sprint_tc_classid(rta_getattr_u32(tb[TCA_MATCHALL_CLASSID]), b1));
>  	}
>  
> +	if (tb[TCA_MATCHALL_FLAGS]) {
> +		__u32 flags = rta_getattr_u32(tb[TCA_MATCHALL_FLAGS]);
> +
> +		if (flags & TCA_CLS_FLAGS_SKIP_HW)
> +			fprintf(f, "\n  skip_hw");
> +		if (flags & TCA_CLS_FLAGS_SKIP_SW)
> +			fprintf(f, "\n  skip_sw");
> +	}
> +
>  	if (tb[TCA_MATCHALL_ACT])
>  		tc_print_action(f, tb[TCA_MATCHALL_ACT]);
>  
> -- 
> 2.3.7
>