[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20170211.210101.1450332574457722492.davem@davemloft.net>
Date: Sat, 11 Feb 2017 21:01:01 -0500 (EST)
From: David Miller <davem@...emloft.net>
To: stephen@...workplumber.org
Cc: shannon.nelson@...cle.com, netdev@...r.kernel.org,
sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 net-next 4/9] sunvnet: add driver stats for ethtool
support
From: Stephen Hemminger <stephen@...workplumber.org>
Date: Fri, 10 Feb 2017 16:22:08 -0800
> On Fri, 10 Feb 2017 09:38:20 -0800
> Shannon Nelson <shannon.nelson@...cle.com> wrote:
>
>> +static void vsw_get_ethtool_stats(struct net_device *dev,
>> + struct ethtool_stats *estats, u64 *data)
>> +{
>> + int i = 0;
>> +
>> + data[i++] = dev->stats.rx_packets;
>> + data[i++] = dev->stats.tx_packets;
>> + data[i++] = dev->stats.rx_bytes;
>> + data[i++] = dev->stats.tx_bytes;
>> + data[i++] = dev->stats.rx_errors;
>> + data[i++] = dev->stats.tx_errors;
>> + data[i++] = dev->stats.rx_dropped;
>> + data[i++] = dev->stats.tx_dropped;
>> + data[i++] = dev->stats.multicast;
>
> Please do not duplicate regular network statistics into ethtool.
> This doesn't really add any value.
Agreed.
Powered by blists - more mailing lists