netdev - Re: [PATCH 1/2] include: Fix checkpatch whitespace error and warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f2c8aa4b-525f-b7b0-8dd0-40d7ff9421eb@cogentembedded.com>
Date:   Sun, 12 Feb 2017 13:39:27 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     "Tobin C. Harding" <me@...in.cc>,
        "David S . Miller" <davem@...emloft.net>
Cc:     mawilcox@...rosoft.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] include: Fix checkpatch whitespace error and warning

Hello!

On 2/12/2017 5:57 AM, Tobin C. Harding wrote:

> This patch fixes two trivial whitespace messages (ERROR/WARNING).
> Fixes trailing whitespace ERROR and fixes space before tabs WARNING.
>
> Signed-off-by: Tobin C. Harding <me@...in.cc>
> ---
>  include/linux/idr.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/idr.h b/include/linux/idr.h
> index 3c01b89..4a8de2f 100644
> --- a/include/linux/idr.h
> +++ b/include/linux/idr.h
> @@ -1,6 +1,6 @@
>  /*
>   * include/linux/idr.h
> - *
> + *
>   * 2002-10-18  written by Jim Houston jim.houston@...r.com
>   *	Copyright (C) 2002 by Concurrent Computer Corporation
>   *	Distributed under the GNU GPL license version 2.
> @@ -183,7 +183,7 @@ static inline void *idr_find(struct idr *idr, int id)
>   */
>  #define IDA_CHUNK_SIZE		128	/* 128 bytes per chunk */
>  #define IDA_BITMAP_LONGS	(IDA_CHUNK_SIZE / sizeof(long) - 1)
> -#define IDA_BITMAP_BITS 	(IDA_BITMAP_LONGS * sizeof(long) * 8)
> +#define IDA_BITMAP_BITS         (IDA_BITMAP_LONGS * sizeof(long) * 8)

    Why replace tab with spaces?!

[...]

MBR, Sergei