netdev - Re: Linux HSR driver question

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58A1D312.2030003@alten.se>
Date:   Mon, 13 Feb 2017 16:38:58 +0100
From:   Arvid Brodin <arvid.brodin@...en.se>
To:     Murali Karicheri <m-karicheri2@...com>
CC:     "open list:TI NETCP ETHERNET DRIVER" <netdev@...r.kernel.org>
Subject: Re: Linux HSR driver question

On 2017-02-09 21:32, Murali Karicheri wrote:
> Hi Arvid,
> 
> While I work to add PRP support to the existing Linux HSR driver, I came across
> a piece of code related to prune node function. The hsr_device.c adds the 
> prune timer in hsr_dev_finalize() by calling
> 
> add_timer(&hsr->prune_timer);
> 
> But it is never restarted in hsr_prune_nodes(). Is that intentional or a bug?
> I tried adding add_timer(&hsr->prune_timer) at the end of  hsr_prune_nodes(),
> but then a iperf test stops with no traffic across the hsr interface and it
> never recovers. I have to delete the interface and create it again to recover.
> Is that the reason, it is currently disabled?
> 

Hi Murali,

Sorry I don't remember the details here. I do know I tested that a node that had
been unplugged for two minutes was forgotten by the other nodes, so this has 
worked at some time in the past, at least. :)


-- 
Arvid Brodin
Linux Consultant
ALTEN Sweden