netdev - Re: [PATCH net] net/llc: avoid BUG_ON() in skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 12 Feb 2017 22:15:36 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     eric.dumazet@...il.com
Cc:     andreyknvl@...gle.com, acme@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] net/llc: avoid BUG_ON() in skb_orphan()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sun, 12 Feb 2017 14:03:52 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> It seems nobody used LLC since linux-3.12.
> 
> Fortunately fuzzers like syzkaller still know how to run this code,
> otherwise it would be no fun.
> 
> Setting skb->sk without skb->destructor leads to all kinds of
> bugs, we now prefer to be very strict about it.
> 
> Ideally here we would use skb_set_owner() but this helper does not exist yet,
> only CAN seems to have a private helper for that.
> 
> Fixes: 376c7311bdb6 ("net: add a temporary sanity check in skb_orphan()")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Andrey Konovalov <andreyknvl@...gle.com>

Applied and queued up for -stable, thanks Eric.