netdev - Re: [PATCH] bpf: reduce compiler warnings by adding fallthrough comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170214000004.GA37569@ast-mbp.thefacebook.com>
Date:   Mon, 13 Feb 2017 16:00:06 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     Alexander Alemayhu <alexander@...mayhu.com>,
        netdev@...r.kernel.org, ast@...nel.org, brouer@...hat.com,
        dcb314@...mail.com, jbacik@...com
Subject: Re: [PATCH] bpf: reduce compiler warnings by adding fallthrough
 comments

On Tue, Feb 14, 2017 at 12:18:05AM +0100, Daniel Borkmann wrote:
> >kernel/bpf/verifier.c:2019:24: warning: this statement may fall through [-Wimplicit-fallthrough=]
> >    false_reg->min_value = 0;
> >    ~~~~~~~~~~~~~~~~~~~~~^~~
> >
> >Reported-by: David Binderman <dcb314@...mail.com>
> >Signed-off-by: Alexander Alemayhu <alexander@...mayhu.com>
> 
> These fall-through comments are fine for net-next tree.
> 
> Acked-by: Daniel Borkmann <daniel@...earbox.net>

lgtm as well
Acked-by: Alexei Starovoitov <ast@...nel.org>