netdev - Re: [PATCH net V2] net/mlx5e: Disable preemption when doing TC statistics upcall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170214.115657.701720927787143085.davem@davemloft.net>
Date:   Tue, 14 Feb 2017 11:56:57 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     ogerlitz@...lanox.com
Cc:     saeedm@...lanox.com, amir@...ai.me, roid@...lanox.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net V2] net/mlx5e: Disable preemption when doing TC
 statistics upcall

From: Or Gerlitz <ogerlitz@...lanox.com>
Date: Sun, 12 Feb 2017 11:21:31 +0200

> When called by HW offloading drivers, the TC action (e.g
> net/sched/act_mirred.c) code uses this_cpu logic, e.g
> 
>  _bstats_cpu_update(this_cpu_ptr(a->cpu_bstats), bytes, packets)
> 
> per the kernel documention, preemption should be disabled, add that.
> 
> Before the fix, when running with CONFIG_PREEMPT set, we get a
> 
> BUG: using smp_processor_id() in preemptible [00000000] code: tc/3793
> 
> asserion from the TC action (mirred) stats_update callback.
> 
> Fixes: aad7e08d39bd ('net/mlx5e: Hardware offloaded flower filter statistics support')
> Signed-off-by: Or Gerlitz <ogerlitz@...lanox.com>

Applied and queued up for -stable, thanks Or.