netdev - Re: [patch net-next 2/6] sched: move tcf_proto_destroy and tcf_destroy_chain helpers into cls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170214172501.GA4182@bistromath.localdomain>
Date:   Tue, 14 Feb 2017 18:25:01 +0100
From:   Sabrina Dubroca <sd@...asysnail.net>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, jhs@...atatu.com,
        mlxsw@...lanox.com
Subject: Re: [patch net-next 2/6] sched: move tcf_proto_destroy and
 tcf_destroy_chain helpers into cls_api

Hi Jiri,

2017-02-09, 14:38:56 +0100, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...lanox.com>
> 
> Creation is done in this file, move destruction to be at the same place.
> 
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>
> ---
>  include/net/pkt_cls.h     |  2 ++
>  include/net/sch_generic.h |  2 --
>  net/sched/cls_api.c       | 21 +++++++++++++++++++++
>  net/sched/sch_api.c       | 22 ----------------------
>  net/sched/sch_atm.c       |  1 +
>  net/sched/sch_cbq.c       |  1 +
>  net/sched/sch_choke.c     |  1 +
>  net/sched/sch_dsmark.c    |  1 +
>  net/sched/sch_fq_codel.c  |  1 +
>  net/sched/sch_htb.c       |  1 +
>  net/sched/sch_ingress.c   |  1 +
>  net/sched/sch_multiq.c    |  2 +-
>  net/sched/sch_prio.c      |  2 +-
>  net/sched/sch_sfb.c       |  1 +
>  net/sched/sch_sfq.c       |  1 +
>  15 files changed, 34 insertions(+), 26 deletions(-)

This broke the build for !NET_CLS:

net/built-in.o: In function `fq_codel_destroy':
/home/sab/linux/net-next/net/sched/sch_fq_codel.c:468: undefined reference to `tcf_destroy_chain'


-- 
Sabrina