netdev - Re: [PATCH net-next v3 2/8] gtp: switch from struct socket to struct sock for the GTP sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170214.124815.217549517821684819.davem@davemloft.net>
Date:   Tue, 14 Feb 2017 12:48:15 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     aschultz@...p.net
Cc:     pablo@...filter.org, netdev@...r.kernel.org, laforge@...monks.org,
        Lionel.Gauthier@...ecom.fr, osmocom-net-gprs@...ts.osmocom.org,
        jonas@...thpole.se
Subject: Re: [PATCH net-next v3 2/8] gtp: switch from struct socket to
 struct sock for the GTP sockets

From: Andreas Schultz <aschultz@...p.net>
Date: Mon, 13 Feb 2017 16:36:18 +0100

> +	if (gtp->sk0) {
> +		udp_sk(gtp->sk0)->encap_type = 0;
> +		rcu_assign_sk_user_data(gtp->sk0, NULL);
> +		sock_put(gtp->sk0);
>  	}

This does "sock_put(NULL);" because you are assigning gtp->sk0 to
NULL before the sock_put() call.  So you are leaking the socket,
at best.

You need to load the socket pointer into a local variable in order
to do this correctly.