netdev - Re: [PATCH V4 net-next 1/2] qed: Add support for hardware offloaded FCoE.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170214.131419.1326744868549008726.davem@davemloft.net>
Date:   Tue, 14 Feb 2017 13:14:19 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     chad.dupuis@...ium.com
Cc:     martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
        fcoe-devel@...n-fcoe.org, netdev@...r.kernel.org,
        yuval.mintz@...ium.com, QLogic-Storage-Upstream@...ium.com
Subject: Re: [PATCH V4 net-next 1/2] qed: Add support for hardware
 offloaded FCoE.

From: "Dupuis, Chad" <chad.dupuis@...ium.com>
Date: Mon, 13 Feb 2017 11:17:00 -0800

> @@ -255,6 +259,10 @@ struct qed_hw_info {
>  	u32				part_num[4];
>  
>  	unsigned char			hw_mac_addr[ETH_ALEN];
> +	u64				node_wwn;
> +	u64				port_wwn;
> +
> +	u16 num_fcoe_conns;

This new num_fcoe_conns member should be indented just like the rest of them.

> +static int
> +qed_sp_fcoe_func_start(struct qed_hwfn *p_hwfn,
> +		       enum spq_mode comp_mode,
> +		       struct qed_spq_comp_cb *p_comp_addr)
> +{
> +	struct qed_fcoe_pf_params *fcoe_pf_params = NULL;
> +	struct fcoe_init_ramrod_params *p_ramrod = NULL;
> +	struct fcoe_conn_context *p_cxt = NULL;
> +	struct qed_spq_entry *p_ent = NULL;
> +	struct fcoe_init_func_ramrod_data *p_data;
> +	int rc = 0;
> +	struct qed_sp_init_data init_data;
> +	struct qed_cxt_info cxt_info;
> +	u32 dummy_cid;
> +	u16 tmp;
> +	u8 i;

Please order local variable declarations from larget the smallest line.

> +#else /* CONFIG_QED_FCOE */
> +static inline struct qed_fcoe_info *
> +qed_fcoe_alloc(struct qed_hwfn *p_hwfn) { return NULL; }
> +static inline void
> +qed_fcoe_setup(struct qed_hwfn *p_hwfn, struct qed_fcoe_info *p_fcoe_info) {}
> +static inline void
> +qed_fcoe_free(struct qed_hwfn *p_hwfn, struct qed_fcoe_info *p_fcoe_info) {}
> +static inline void
> +qed_get_protocol_stats_fcoe(struct qed_dev *cdev,
> +			    struct qed_mcp_fcoe_stats *stats) {}

Please do not format these functions so compactly, they are very difficult to
read.  Format them just like normal functions.