netdev - Re: [PATCH 2/2] pcnet32: fix BNC/AUI port on AM79C970A

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170214.142856.670670406050328036.davem@davemloft.net>
Date:   Tue, 14 Feb 2017 14:28:56 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     linux@...nbow-software.org
Cc:     pcnet32@...ntier.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] pcnet32: fix BNC/AUI port on AM79C970A

From: Ondrej Zary <linux@...nbow-software.org>
Date: Mon, 13 Feb 2017 23:45:47 +0100

> Even though the port autoselection is enabled by default on AM79C970A,
> BNC/AUI port does not work because the link is always reported to be
> down. The link state reported by the chip belongs only to the TP port
> but the driver uses it regardless of the port used. The chip can't
> detect BNC/AUI link state.
> 
> Disable port autoselection and use TP port by default to keep current
> behavior (link detection works on TP port, BNC/AUI port does not work).
> 
> Implement ethtool autoneg, port and duplex configuration to allow
> using the BNC/AUI port.
> 
> Report the TP link state only if the TP port is selected. When the
> port autoselection is enabled or AUI port is selected, report the link
> as always up.
> 
> Move pcnet32_suspend() and pcnet32_clr_suspend() functions to avoid
> forward declarations.
> 
> Signed-off-by: Ondrej Zary <linux@...nbow-software.org>

Also applied to net-next, thanks.

Are you really sure the is no way to discover the BNC/AUI link state
from the hardware?