netdev - Re: [PATCH] net: au1000_eth: get rid of unnecessary header.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170214.145306.2134798979815682111.davem@davemloft.net>
Date:   Tue, 14 Feb 2017 14:53:06 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     manuel.lauss@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] net: au1000_eth: get rid of unnecessary header.

From: Manuel Lauss <manuel.lauss@...il.com>
Date: Tue, 14 Feb 2017 13:11:07 +0100

> au1000_eth.h isn't used anywhere else, merge its contents into
> main driver file.
> 
> Signed-off-by: Manuel Lauss <manuel.lauss@...il.com>

It is completely natural and normal to split the datastructure and
defines into a header file, used by only one file, the driver.

I'm not applying this, it doesn't really improve anything.

Thanks.