netdev - Re: [PATCH net v2] ibmvnic: Fix initial MTU settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170214.145810.826153305226199095.davem@davemloft.net>
Date:   Tue, 14 Feb 2017 14:58:10 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     tlfalcon@...ux.vnet.ibm.com
Cc:     netdev@...r.kernel.org, nfont@...ux.vnet.ibm.com,
        jallen@...ux.vnet.ibm.com
Subject: Re: [PATCH net v2] ibmvnic: Fix initial MTU settings

From: Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>
Date: Tue, 14 Feb 2017 10:22:59 -0600

> In the current driver, the MTU is set to the maximum value
> capable for the backing device. This decision turned out to
> be a mistake as it led to confusion among users. The expected
> initial MTU value used for other IBM vNIC capable operating
> systems is 1500, with the maximum value (9000) reserved for
> when Jumbo frames are enabled. This patch sets the MTU to
> the default value for a net device.
> 
> It also corrects a discrepancy between MTU values received from
> firmware, which includes the ethernet header length, and net
> device MTU values.
> 
> Finally, it removes redundant min/max MTU assignments after device
> initialization.
> 
> Signed-off-by: Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>
> ---
> v2: included more detailed commit message addressing why
>     this patch is needed

Applied, thanks.