netdev - Re: [PATCH 1/3] net: stmicro: prepare dwmac4 core for mtl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201702150643.txPgiQ6O%fengguang.wu@intel.com>
Date:   Wed, 15 Feb 2017 06:13:31 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Joao Pinto <Joao.Pinto@...opsys.com>
Cc:     kbuild-all@...org, davem@...emloft.net, peppe.cavallaro@...com,
        alexandre.torgue@...com, netdev@...r.kernel.org,
        Joao Pinto <Joao.Pinto@...opsys.com>
Subject: Re: [PATCH 1/3] net: stmicro: prepare dwmac4 core for mtl

Hi Joao,

[auto build test WARNING on net-next/master]
[also build test WARNING on next-20170214]
[cannot apply to v4.10-rc8]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Joao-Pinto/add-support-for-multiple-queues-channels-in-stmmac/20170215-024621
config: i386-randconfig-x002-201707 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c: In function 'stmmac_set_pauseparam':
   drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:505:6: warning: unused variable 'queue' [-Wunused-variable]
     u32 queue = 0;
         ^~~~~
   drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c: In function 'stmmac_get_ethtool_stats':
>> drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:546:9: warning: 'j' may be used uninitialized in this function [-Wmaybe-uninitialized]
     int i, j, queue = 0;
            ^

vim +/j +546 drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c

   499			      struct ethtool_pauseparam *pause)
   500	{
   501		struct stmmac_priv *priv = netdev_priv(netdev);
   502		u32 tx_queues_count = priv->dma_cap.number_tx_queues;
   503		struct phy_device *phy = netdev->phydev;
   504		int new_pause = FLOW_OFF;
 > 505		u32 queue = 0;
   506	
   507		if (priv->hw->pcs && priv->hw->mac->pcs_get_adv_lp) {
   508			struct rgmii_adv adv_lp;
   509	
   510			pause->autoneg = 1;
   511			priv->hw->mac->pcs_get_adv_lp(priv->ioaddr, &adv_lp);
   512			if (!adv_lp.pause)
   513				return -EOPNOTSUPP;
   514		} else {
   515			if (!(phy->supported & SUPPORTED_Pause) ||
   516			    !(phy->supported & SUPPORTED_Asym_Pause))
   517				return -EOPNOTSUPP;
   518		}
   519	
   520		if (pause->rx_pause)
   521			new_pause |= FLOW_RX;
   522		if (pause->tx_pause)
   523			new_pause |= FLOW_TX;
   524	
   525		priv->flow_ctrl = new_pause;
   526		phy->autoneg = pause->autoneg;
   527	
   528		if (phy->autoneg) {
   529			if (netif_running(netdev))
   530				return phy_start_aneg(phy);
   531		}
   532	
   533		priv->hw->mac->flow_ctrl(priv->hw, phy->duplex, priv->flow_ctrl,
   534					 priv->pause, tx_queues_count);
   535	
   536		return 0;
   537	}
   538	
   539	static void stmmac_get_ethtool_stats(struct net_device *dev,
   540					 struct ethtool_stats *dummy, u64 *data)
   541	{
   542		struct stmmac_priv *priv = netdev_priv(dev);
   543		u32 rx_queues_count = priv->dma_cap.number_rx_queues;
   544		u32 tx_queues_count = priv->dma_cap.number_tx_queues;
   545		u32 queue_count = 0;
 > 546		int i, j, queue = 0;
   547	
   548		queue_count = (tx_queues_count > rx_queues_count) ?
   549			      tx_queues_count : rx_queues_count;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (32175 bytes)