netdev - Re: [PATCH] NET: Fix /proc/net/arp for AX.25

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170213.221551.904691736246648194.davem@davemloft.net>
Date:   Mon, 13 Feb 2017 22:15:51 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     ralf@...ux-mips.org
Cc:     netdev@...r.kernel.org, thomas@...erried.de,
        linux-hams@...r.kernel.org
Subject: Re: [PATCH] NET: Fix /proc/net/arp for AX.25

From: Ralf Baechle <ralf@...ux-mips.org>
Date: Sat, 11 Feb 2017 00:38:57 +0100

> When sending ARP requests over AX.25 links the hwaddress in the neighbour
> cache are not getting initialized.  For such an incomplete arp entry
> ax2asc2 will generate an empty string resulting in /proc/net/arp output
> like the following:
> 
> $ cat /proc/net/arp
> IP address       HW type     Flags       HW address            Mask     Device
> 192.168.122.1    0x1         0x2         52:54:00:00:5d:5f     *        ens3
> 172.20.1.99      0x3         0x0              *        bpq0
> 
> The missing field will confuse the procfs parsing of arp(8) resulting in
> incorrect output for the device such as the following:
> 
> $ arp
> Address                  HWtype  HWaddress           Flags Mask            Iface
> gateway                  ether   52:54:00:00:5d:5f   C                     ens3
> 172.20.1.99                      (incomplete)                              ens3
> 
> This changes the content of /proc/net/arp to:
> 
> $ cat /proc/net/arp
> IP address       HW type     Flags       HW address            Mask     Device
> 172.20.1.99      0x3         0x0         *                     *        bpq0
> 192.168.122.1    0x1         0x2         52:54:00:00:5d:5f     *        ens3
> 
> To do so it change ax2asc to put the string "*" in buf for a NULL address
> argument.  Finally the HW address field is left aligned in a 17 character
> field (the length of an ethernet HW address in the usual hex notation) for
> readability.
> 
> Signed-off-by: Ralf Baechle <ralf@...ux-mips.org>

Applied, thanks Ralf.