netdev - Re: [PATCH v2 net] packet: Do not call fanout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Feb 2017 01:15:30 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Anoob Soman <anoob.soman@...rix.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org, davem@...emloft.net,
        eric.dumazet@...il.com, Anoob Soman <anoob.soman@...rix.com>
Subject: Re: [PATCH v2 net] packet: Do not call fanout_release from atomic
 contexts

Hi Anoob,

[auto build test WARNING on net-next/master]
[also build test WARNING on v4.10-rc8]
[cannot apply to net/master next-20170215]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Anoob-Soman/packet-Do-not-call-fanout_release-from-atomic-contexts/20170216-004744
config: x86_64-randconfig-x008-201707 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   net/packet/af_packet.c: In function 'fanout_release':
>> net/packet/af_packet.c:1739:3: warning: 'return' with no value, in function returning non-void [-Wreturn-type]
      return;
      ^~~~~~
   net/packet/af_packet.c:1731:30: note: declared here
    static struct packet_fanout *fanout_release(struct sock *sk)
                                 ^~~~~~~~~~~~~~

vim +/return +1739 net/packet/af_packet.c

dc99f600 David S. Miller 2011-07-05  1723  	return err;
dc99f600 David S. Miller 2011-07-05  1724  }
dc99f600 David S. Miller 2011-07-05  1725  
53d5c353 Anoob Soman     2017-02-15  1726  /* If pkt_sk(sk)->fanout->sk_ref is zero, this functuon removes
53d5c353 Anoob Soman     2017-02-15  1727   * pkt_sk(sk)->fanout from fanout_list and returns pkt_sk(sk)->fanout.
53d5c353 Anoob Soman     2017-02-15  1728   * It is the responsibility of the caller to call fanout_release_data() and
53d5c353 Anoob Soman     2017-02-15  1729   * free the returned packet_fanout (after synchronize_net())
53d5c353 Anoob Soman     2017-02-15  1730   */
53d5c353 Anoob Soman     2017-02-15  1731  static struct packet_fanout *fanout_release(struct sock *sk)
dc99f600 David S. Miller 2011-07-05  1732  {
dc99f600 David S. Miller 2011-07-05  1733  	struct packet_sock *po = pkt_sk(sk);
dc99f600 David S. Miller 2011-07-05  1734  	struct packet_fanout *f;
53d5c353 Anoob Soman     2017-02-15  1735  	bool ret_fanout = false;
dc99f600 David S. Miller 2011-07-05  1736  
dc99f600 David S. Miller 2011-07-05  1737  	f = po->fanout;
dc99f600 David S. Miller 2011-07-05  1738  	if (!f)
dc99f600 David S. Miller 2011-07-05 @1739  		return;
dc99f600 David S. Miller 2011-07-05  1740  
fff3321d Pavel Emelyanov 2012-08-16  1741  	mutex_lock(&fanout_mutex);
dc99f600 David S. Miller 2011-07-05  1742  	po->fanout = NULL;
dc99f600 David S. Miller 2011-07-05  1743  
dc99f600 David S. Miller 2011-07-05  1744  	if (atomic_dec_and_test(&f->sk_ref)) {
dc99f600 David S. Miller 2011-07-05  1745  		list_del(&f->list);
53d5c353 Anoob Soman     2017-02-15  1746  		ret_fanout = true;
dc99f600 David S. Miller 2011-07-05  1747  	}

:::::: The code at line 1739 was first introduced by commit
:::::: dc99f600698dcac69b8f56dda9a8a00d645c5ffc packet: Add fanout support.

:::::: TO: David S. Miller <davem@...emloft.net>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (31218 bytes)