netdev - Re: [PATCH] average: change to declare precision, not factor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170215.125403.419777696065228170.davem@davemloft.net>
Date:   Wed, 15 Feb 2017 12:54:03 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     johannes@...solutions.net
Cc:     linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        mst@...hat.com, jasowang@...hat.com,
        virtualization@...ts.linux-foundation.org,
        mareklindner@...mailbox.ch, sw@...onwunderlich.de, a@...table.cc,
        sgruszka@...hat.com, johannes.berg@...el.com
Subject: Re: [PATCH] average: change to declare precision, not factor

From: Johannes Berg <johannes@...solutions.net>
Date: Wed, 15 Feb 2017 09:49:26 +0100

> From: Johannes Berg <johannes.berg@...el.com>
> 
> Declaring the factor is counter-intuitive, and people are prone
> to using small(-ish) values even when that makes no sense.
> 
> Change the DECLARE_EWMA() macro to take the fractional precision,
> in bits, rather than a factor, and update all users.
> 
> While at it, add some more documentation.
> 
> Signed-off-by: Johannes Berg <johannes.berg@...el.com>
> ---
> Unless I hear any objections, I will take this through my tree.

Acked-by: David S. Miller <davem@...emloft.net>