netdev - Re: [PATCH net-next V3 6/7] net/sched: cls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170215.131621.1024613955864556616.davem@davemloft.net>
Date:   Wed, 15 Feb 2017 13:16:21 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     ogerlitz@...lanox.com
Cc:     jakub.kicinski@...ronome.com, john.r.fastabend@...el.com,
        jhs@...atatu.com, roid@...lanox.com, jiri@...lanox.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next V3 6/7] net/sched: cls_u32: Reflect HW offload
 status

From: Or Gerlitz <ogerlitz@...lanox.com>
Date: Wed, 15 Feb 2017 10:52:36 +0200

> @@ -895,6 +899,9 @@ static int u32_change(struct net *net, struct sk_buff *in_skb,
>  			return err;
>  		}
>  
> +		if (!(tc_in_hw(new->flags)))

Less parenthesis, please.

> @@ -1014,6 +1021,9 @@ static int u32_change(struct net *net, struct sk_buff *in_skb,
>  		if (err)
>  			goto errhw;
>  
> +		if (!(tc_in_hw(n->flags)))

Likewise.