netdev - Re: [PATCH net-next 01/13] net: ethernet: aquantia: Removed extra assignment for skb->dev.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea14de65-6ad8-7601-aadc-6be1fc1ebb88@gmx.de>
Date:   Wed, 15 Feb 2017 21:53:54 +0100
From:   Lino Sanfilippo <LinoSanfilippo@....de>
To:     Pavel Belous <Pavel.Belous@...antia.com>,
        "David S . Miller" <davem@...emloft.net>
Cc:     netdev@...r.kernel.org,
        Simon Edelhaus <Simon.Edelhaus@...antia.com>,
        Alexey Andriyanov <Alexey.Andriyanov@...antia.com>
Subject: Re: [PATCH net-next 01/13] net: ethernet: aquantia: Removed extra
 assignment for skb->dev.

Hi,

On 15.02.2017 21:01, Pavel Belous wrote:
> From: Pavel Belous <pavel.belous@...antia.com>
>
> This assignment is not needed.
>
> Signed-off-by: Pavel Belous <pavel.belous@...antia.com>
> ---
>  drivers/net/ethernet/aquantia/atlantic/aq_ring.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
> index dea9e9b..4c40644 100644
> --- a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
> +++ b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c
> @@ -214,7 +214,6 @@ int aq_ring_rx_clean(struct aq_ring_s *self, int *work_done, int budget)
>  				goto err_exit;
>  			}
>
> -			skb->dev = ndev;
>  			skb_put(skb, buff->len);
>  		} else {
>  			skb = netdev_alloc_skb(ndev, ETH_HLEN);
>

Reviewed-by: Lino Sanfilippo <LinoSanfilippo@....de>