netdev - Re: [PATCH net] tcp: tcp_probe: use spin_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170214222410.5ccbd61d@plumbers-lap.home.lan>
Date:   Tue, 14 Feb 2017 22:24:10 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     Ricardo Nabinger Sanchez <rnsanchez@...il.com>,
        David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net] tcp: tcp_probe: use spin_lock_bh()

On Tue, 14 Feb 2017 17:11:14 -0800
Eric Dumazet <eric.dumazet@...il.com> wrote:

> From: Eric Dumazet <edumazet@...gle.com>
> 
> tcp_rcv_established() can now run in process context.
> 
> We need to disable BH while acquiring tcp probe spinlock,
> or risk a deadlock.
> 
> Fixes: 5413d1babe8f ("net: do not block BH while processing socket backlog")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Ricardo Nabinger Sanchez <rnsanchez@...il.com>

Thanks. Also glad to see people are still using TCP probe.