netdev - Re: [PATCH] net: hip04: Omit private ndo_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1487155881.6214.54.camel@perches.com>
Date:   Wed, 15 Feb 2017 02:51:21 -0800
From:   Joe Perches <joe@...ches.com>
To:     Tobias Klauser <tklauser@...tanz.ch>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] net: hip04: Omit private ndo_get_stats function

On Wed, 2017-02-15 at 11:38 +0100, Tobias Klauser wrote:
> On 2017-02-15 at 11:28:08 +0100, Joe Perches <joe@...ches.com> wrote:
> > On Tue, 2017-02-14 at 15:10 +0100, Tobias Klauser wrote:
> > > hip04_get_stats() just returns dev->stats so we can leave it
> > > out altogether and let dev_get_stats() do the job.
> > 
> > This could be done for at least a few more drivers:
> > 
> > drivers/net/ethernet/chelsio/cxgb/sge.c
> 
> I don't see an .ndo_get_stats being defined/set in this file. AFAICT,
> this driver sets .ndo_get_stats to t1_get_stats(), which does some
> additional extraction of statistics from device registers and thus
> shouldn't be removed.

Right.

> > drivers/net/ethernet/intel/e1000/e1000_main.c
> > drivers/net/ethernet/intel/ixgb/ixgb_main.c
> 
> Will cover these in follow-up patches, thanks.

Thanks.

> > drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
> 
> A patch for pch_gbe already landed in net-next.

Great, cheers, Joe