netdev - Re: [PATCH net-next v7 1/2] qed: Add infrastructure for PTP support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1487248919.1311.39.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Thu, 16 Feb 2017 04:41:59 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Yuval Mintz <Yuval.Mintz@...ium.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        richardcochran@...il.com, Sudarsana.Kalluru@...ium.com
Subject: Re: [PATCH net-next v7 1/2] qed: Add infrastructure for PTP support

On Wed, 2017-02-15 at 10:24 +0200, Yuval Mintz wrote:
> From: Sudarsana Reddy Kalluru <sudarsana.Kalluru@...ium.com>
> 
> The patch adds the required qed interfaces for configuring/reading
> the PTP clock on the adapter.


> +/* Read Phy Hardware Clock */
> +static int qed_ptp_hw_read_cc(struct qed_dev *cdev, u64 *phc_cycles)
> +{
> +	struct qed_hwfn *p_hwfn = QED_LEADING_HWFN(cdev);
> +	struct qed_ptt *p_ptt = p_hwfn->p_ptp_ptt;
> +	u32 temp = 0;
> +
> +	temp = qed_rd(p_hwfn, p_ptt, NIG_REG_TSGEN_SYNC_TIME_LSB);
> +	*phc_cycles = qed_rd(p_hwfn, p_ptt, NIG_REG_TSGEN_SYNC_TIME_MSB);
> +	*phc_cycles <<= 32;
> +	*phc_cycles |= temp;
> +
> +	return 0;
> +}

LSB and MSB being read non atomically, it looks like you could have an
error of (1<<32) cycles here.

(You read LSB value close to 0xFFFFFFFF right before it changes to 0,
while MSB got incremented.)