netdev - Re: [PATCH] net: bgmac: store MAC address directly in netdev->dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170217.130351.2166612074816910690.davem@davemloft.net>
Date:   Fri, 17 Feb 2017 13:03:51 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     tklauser@...tanz.ch
Cc:     netdev@...r.kernel.org, rafal@...ecki.pl, f.fainelli@...il.com,
        jon.mason@...adcom.com, arnd@...db.de
Subject: Re: [PATCH] net: bgmac: store MAC address directly in
 netdev->dev_addr

From: Tobias Klauser <tklauser@...tanz.ch>
Date: Thu, 16 Feb 2017 15:11:19 +0100

> After commit 34a5102c3235 ("net: bgmac: allocate struct bgmac just once
> & don't copy it") the mac_addr member of struct bgmac is no longer
> necessary to pass the MAC address to bgmac_enet_probe(). Instead it can
> directly be stored in netdev->dev_addr.
> 
> Also use eth_hw_addr_random() instead of eth_random_addr() in case a
> random MAC is nedded. This will make sure netdev->addr_assign_type will
> be properly set.
> 
> Signed-off-by: Tobias Klauser <tklauser@...tanz.ch>

Applied to net-next, thank you.