netdev - Re: [PATCH net-next 1/1] pkt_sched: Remove useless qdisc_stab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1487355744.1311.88.camel@edumazet-glaptop3.roam.corp.google.com>
Date:   Fri, 17 Feb 2017 10:22:24 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     fgao@...ai8.com, David Miller <davem@...emloft.net>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Feng Gao <gfree.wind@...il.com>
Subject: Re: [PATCH net-next 1/1] pkt_sched: Remove useless qdisc_stab_lock

On Fri, 2017-02-17 at 10:02 -0800, Cong Wang wrote:
> On Thu, Feb 16, 2017 at 10:34 PM,  <fgao@...ai8.com> wrote:
> > From: Gao Feng <fgao@...ai8.com>
> >
> > The qdisc_stab_lock is used in qdisc_get_stab and qdisc_put_stab.
> > These two functions are invoked in qdisc_create, qdisc_change, and
> > qdisc_destroy which run fully under RTNL.
> >
> > So it already makes sure only one could access the qdisc_stab_list at
> > the same time. Then it is unnecessary to use qdisc_stab_lock now.
> 
> I posted a (almost) same patch two years ago:
> http://marc.info/?l=linux-netdev&m=141512383516640&w=2
> 
> Forget why it was not accepted at that time.

Probably because you sent a huge patch serie, and I was not willing to
spend a full day reviewing it.

Sorry.