netdev - Re: [PATCH net-next v2 3/6] net: dsa: mv88e6xxx: add support for 6390 ATU Move

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170217213802.GI6096@lunn.ch>
Date:   Fri, 17 Feb 2017 22:38:02 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...oirfairelinux.com,
        "David S. Miller" <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH net-next v2 3/6] net: dsa: mv88e6xxx: add support for
 6390 ATU Move

On Fri, Feb 17, 2017 at 10:05:28AM -0500, Vivien Didelot wrote:
> The 6390 family of Marvell chips uses 5 bits to describe the ToPort and
> FromPort values of PortVec in the ATU Move operation, while older
> switches use 0xf.

Hi Vivien

Since you say 5 bits for 6390, it would be better to say 4 bits for
older switches.

Otherwise:

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew