netdev - Re: [PATCH net-next] bridge: vlan_tunnel: explicitly reset metadata attrs to NULL on failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <79d26bd3-ce7d-9f01-fe45-dc09017021a7@cumulusnetworks.com>
Date:   Fri, 17 Feb 2017 10:49:20 +0100
From:   Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
To:     Roopa Prabhu <roopa@...ulusnetworks.com>, davem@...emloft.net
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next] bridge: vlan_tunnel: explicitly reset metadata
 attrs to NULL on failure

On 16/02/17 20:29, Roopa Prabhu wrote:
> From: Roopa Prabhu <roopa@...ulusnetworks.com>
> 
> Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support")
> Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>
> ---
>  net/bridge/br_vlan_tunnel.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/net/bridge/br_vlan_tunnel.c b/net/bridge/br_vlan_tunnel.c
> index b2b79a0..6d2c4ee 100644
> --- a/net/bridge/br_vlan_tunnel.c
> +++ b/net/bridge/br_vlan_tunnel.c
> @@ -85,6 +85,8 @@ static int __vlan_tunnel_info_add(struct net_bridge_vlan_group *vg,
>  	return 0;
>  out:
>  	dst_release(&vlan->tinfo.tunnel_dst->dst);
> +	vlan->tinfo.tunnel_dst = NULL;
> +	vlan->tinfo.tunnel_id = 0;
>  
>  	return err;
>  }
> 

Reviewed-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>