netdev - Re: [PATCH net] mlx4: fix potential divide by 0 in mlx4_en_auto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALzJLG8FSEz67qRxzqp9DT5AF=RkS-5HqdaQGKwQmuuNWjs0Ew@mail.gmail.com>
Date:   Mon, 20 Feb 2017 00:21:19 +0200
From:   Saeed Mahameed <saeedm@....mellanox.co.il>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Tariq Toukan <tariqt@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Matan Barak <matanb@...lanox.com>, jackm@...lanox.com
Subject: Re: [PATCH net] mlx4: fix potential divide by 0 in mlx4_en_auto_moderation()

On Fri, Feb 17, 2017 at 1:23 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> From: Eric Dumazet <edumazet@...gle.com>
>
> 1) In the case where rate == priv->pkt_rate_low == priv->pkt_rate_high,
> mlx4_en_auto_moderation() does a divide by zero.
>
> 2) We want to properly change the moderation parameters if rx_frames
> was changed (like in ethtool -C eth0 rx-frames 16)
>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Reviewed-by: Saeed Mahameed <saeedm@...lanox.com>