netdev - Re: [PATCH net] ibmvnic: Make CRQ interrupt tasklet wait for all capabilities crqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170219.181222.1275918068118644004.davem@davemloft.net>
Date:   Sun, 19 Feb 2017 18:12:22 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     tlfalcon@...ux.vnet.ibm.com
Cc:     netdev@...r.kernel.org, nfont@...ux.vnet.ibm.com,
        jallen@...ux.vnet.ibm.com
Subject: Re: [PATCH net] ibmvnic: Make CRQ interrupt tasklet wait for all
 capabilities crqs

From: Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>
Date: Wed, 15 Feb 2017 12:18:00 -0600

> After sending device capability queries and requests to the vNIC Server,
> an interrupt is triggered and the responses are written to the driver's
> CRQ response buffer. Since the interrupt can be triggered before all
> responses are written and visible to the partition, there is a danger
> that the interrupt handler or tasklet can terminate before all responses
> are read, resulting in a failure to initialize the device.
> 
> To avoid this scenario, when capability commands are sent, we set
> a flag that will be checked in the following interrupt tasklet that
> will handle the capability responses from the server. Once all
> responses have been handled, the flag is disabled; and the tasklet
> is allowed to terminate.
> 
> Signed-off-by: Thomas Falcon <tlfalcon@...ux.vnet.ibm.com>

Applied.